Android: Use virtualized context only for those with compatible config

ui/gl/gl_surface_osmesa.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface_osmesa.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "third_party/mesa/src/include/GL/osmesa.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/scoped_make_current.h"
 
 namespace gfx {
 
 GLSurfaceOSMesa::GLSurfaceOSMesa(OSMesaSurfaceFormat format,
                                  const gfx::Size& size)
     : size_(size) {
   switch (format) {
     case OSMesaSurfaceFormatBGRA:
-      format_ = OSMESA_BGRA;
+      format_ = static_cast<GLSurface::Format>(OSMESA_BGRA);

[no sievers, 2016/02/19 20:25:18]

hmm this seems like a hack. how about just adding OSMESA_BGRA and _RGBA to the
GLSurface enum?

And then in GLContextOSMesa where this is used you can just have a little switch
statement that converts it to a mesa GLenum. (This is actually a bit hacky in
mesa itself since it mixes actual GL formats with arbitrary mesa defines.)

[Jinsuk Kim, 2016/02/20 13:56:57]

Had meant to do it but didn't. This is certainly better. Done.

       break;
     case OSMesaSurfaceFormatRGBA:
-      format_ = OSMESA_RGBA;
+      format_ = static_cast<GLSurface::Format>(OSMESA_RGBA);
       break;
   }
   // Implementations of OSMesa surface do not support having a 0 size. In such
   // cases use a (1, 1) surface.
   if (size_.GetArea() == 0)
     size_.SetSize(1, 1);
 }
 
 bool GLSurfaceOSMesa::Initialize(GLSurface::Format format) {
   return Resize(size_, 1.f, true);
@@ skipping 58 matching lines @@
 }
 
 gfx::Size GLSurfaceOSMesa::GetSize() {
   return size_;
 }
 
 void* GLSurfaceOSMesa::GetHandle() {
   return buffer_.get();
 }
 
-unsigned GLSurfaceOSMesa::GetFormat() {
-  return format_;
-}
-
 GLSurfaceOSMesa::~GLSurfaceOSMesa() {
   Destroy();
 }
 
 bool GLSurfaceOSMesaHeadless::IsOffscreen() { return false; }
 
 gfx::SwapResult GLSurfaceOSMesaHeadless::SwapBuffers() {
   return gfx::SwapResult::SWAP_ACK;
 }
 
 GLSurfaceOSMesaHeadless::GLSurfaceOSMesaHeadless()
     : GLSurfaceOSMesa(OSMesaSurfaceFormatBGRA, gfx::Size(1, 1)) {
 }
 
 GLSurfaceOSMesaHeadless::~GLSurfaceOSMesaHeadless() { Destroy(); }
 
 }  // namespace gfx