Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1652853002: Editing: isVisuallyEquivalentCandidate() should return false for Position with Document. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: isVisuallyEquivalentCandidate() should return false for Position with Document. We assume we can't put the caret on Document and documentElement. BUG=530442 TEST=automated Committed: https://crrev.com/e5a5d091519221053a65318c58a957b46e18648b Cr-Commit-Position: refs/heads/master@{#372605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-02-01 04:30:05 UTC) #2
yosin_UTC9
lgtm
4 years, 10 months ago (2016-02-01 04:41:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652853002/1
4 years, 10 months ago (2016-02-01 04:42:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 04:47:37 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 04:48:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5a5d091519221053a65318c58a957b46e18648b
Cr-Commit-Position: refs/heads/master@{#372605}

Powered by Google App Engine
This is Rietveld 408576698