third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 1652853002: Editing: isVisuallyEquivalentCandidate() should return false for Position with Document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 1652853002: Editing: isVisuallyEquivalentCandidate() should return false for Position with Document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index a740e5cf6125fc2483ceaa3369aa6a3e85090e46..bd6c359ab6679d28d03773134df8fcaf7509a3f1 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -2789,7 +2789,7 @@ static bool isVisuallyEquivalentCandidateAlgorithm(const PositionTemplate<Strate

return parent->layoutObject() && parent->layoutObject()->isSelectable();

}

- if (anchorNode->document().documentElement() == anchorNode)

+ if (anchorNode->document().documentElement() == anchorNode || anchorNode->isDocumentNode())

return false;

if (!layoutObject->isSelectable())

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp » ('j') | no next file with comments »