Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 165283003: Revert 251206 "Fixes crashes wrt to the maximize button when:" (Closed)

Created:
6 years, 10 months ago by sky
Modified:
6 years, 10 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251206 "Fixes crashes wrt to the maximize button when:" > Fixes crashes wrt to the maximize button when: > - A user hovers the minimize button with the mouse then taps the snap left / snap right button > - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug) > > BUG=342867 > TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch > > Review URL: https://codereview.chromium.org/160493004 Reverting as broke compile on windows: [2431/3743] CXX obj\chrome\browser\extensions\api\cast_channel\browser_extensions.cast_auth_util_nss.obj FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj.rsp /c ..\..\ash\wm\caption_buttons\maximize_bubble_controller.cc /Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\ash.custom_frame_view_ash.obj.rsp /c ..\..\ash\wm\custom_frame_view_ash.cc /Foobj\ash\wm\ash.custom_frame_view_ash.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj.rsp /c ..\..\ash\wm\caption_buttons\frame_caption_button_container_view.cc /Foobj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj.rsp /c ..\..\ash\wm\caption_buttons\maximize_bubble_controller_bubble.cc /Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.frame_maximize_button.obj.rsp /c ..\..\ash\wm\caption_buttons\frame_maximize_button.cc /Foobj\ash\wm\caption_buttons\ash.frame_maximize_button.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods ninja: build stopped: subcommand failed. from: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/14916/steps/compile/logs/stdio#error1 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -69 lines) Patch
M trunk/src/ash/wm/caption_buttons/frame_maximize_button.h View 3 chunks +1 line, -7 lines 0 comments Download
M trunk/src/ash/wm/caption_buttons/frame_maximize_button.cc View 5 chunks +33 lines, -32 lines 0 comments Download
M trunk/src/ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
6 years, 10 months ago (2014-02-14 01:08:43 UTC) #1
sky
6 years, 10 months ago (2014-02-14 01:08:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r251217 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698