Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 160493004: Fix crashes wrt to maximize button and touch (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Fixes crashes wrt to the maximize button when: - A user hovers the minimize button with the mouse then taps the snap left / snap right button - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug) BUG=342867 TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251206

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -34 lines) Patch
M ash/wm/caption_buttons/frame_maximize_button.h View 3 chunks +7 lines, -1 line 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button.cc View 1 5 chunks +32 lines, -33 lines 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
Stefan, can you please take a look?
6 years, 10 months ago (2014-02-13 02:19:14 UTC) #1
Mr4D (OOO till 08-26)
Please see comment https://codereview.chromium.org/160493004/diff/280001/ash/wm/caption_buttons/frame_maximize_button.cc File ash/wm/caption_buttons/frame_maximize_button.cc (right): https://codereview.chromium.org/160493004/diff/280001/ash/wm/caption_buttons/frame_maximize_button.cc#newcode234 ash/wm/caption_buttons/frame_maximize_button.cc:234: wm::GetWindowState(window)->RemoveObserver(this); Shouldn't this be an AddObserver?
6 years, 10 months ago (2014-02-13 15:14:32 UTC) #2
pkotwicz
Stefan, can you please take another look?
6 years, 10 months ago (2014-02-13 15:57:19 UTC) #3
Mr4D (OOO till 08-26)
lgtm
6 years, 10 months ago (2014-02-13 16:32:45 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-13 19:26:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160493004/340001
6 years, 10 months ago (2014-02-13 19:29:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160493004/340001
6 years, 10 months ago (2014-02-13 20:04:46 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 00:35:29 UTC) #8
Message was sent while issue was closed.
Change committed as 251206

Powered by Google App Engine
This is Rietveld 408576698