Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652813004: Blink is non compliant to the css-backgrounds spec where a border with an image (Closed)

Created:
4 years, 10 months ago by cavalcantii1
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink is non compliant to the css-backgrounds spec where a border with an image should *not* be rendered *if* no border style is defined. This patch ensures that Blink will behave like FF and IE. As Blink now is compliant, previous border image tests had to be edited to ensure that a border image will be rendered. A side effect is that websites that are relying on this behavior will broke (e.g. gmail and gcalendar). BUG=559258

Patch Set 1 #

Patch Set 2 : Rebased with current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +38 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/images/pixelated-border-image.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-01.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-border-radius.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-longhand.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-massive-scale.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-omit-right-slice.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-outset.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-outset-in-shorthand.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-outset-split-inline.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-outset-split-inline-vertical-lr.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-repeat.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-repeat-round.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-rotate-transform.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-scale-transform.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-scaled.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-scrambled.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/borders/border-image-should-not-display.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/borders/border-image-should-not-display-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-side-reduction.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-slice-constrained.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-slices.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-source.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-image-trumps-radius.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/borders/resources/red.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/scaled-border-image.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/border-image-style-none.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/border-image-style-none-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/gradients/border-image-gradient.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-comparison.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-comparison-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/webp-flip.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/border-outline-0.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/border-image-vertical-lr.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/border-image-vertical-rl.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/decode-resize.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/scrollbars/listbox-scrollbar-combinations.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/as-border-image/svg-as-border-image.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/as-border-image/svg-as-border-image-2.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderData.h View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderValue.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
cavalcantii1
Adding TimLoh as he helped reviewing the patch in a previous iteration.
4 years, 10 months ago (2016-02-02 19:54:05 UTC) #2
Timothy Loh
On 2016/02/02 19:54:05, cavalcantii1 wrote: > Adding TimLoh as he helped reviewing the patch in ...
4 years, 10 months ago (2016-02-10 02:28:41 UTC) #3
Timothy Loh
4 years, 8 months ago (2016-04-11 06:37:02 UTC) #4 
closing this since we've fixed this in a separate CL

Powered by Google App Engine
This is Rietveld 408576698