Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 165273002: Put the logic to maximize/fullscreen window back in OnWindowAddedToLayout (Closed)

Created:
6 years, 10 months ago by oshima
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, pkotwicz
Visibility:
Public.

Description

Put the logic to maximize/fullscreen window back in OnWindowAddedToLayout I'll look into if we can eliminate this. BUG=343696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251313

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 19 (0 generated)
oshima
6 years, 10 months ago (2014-02-13 23:42:16 UTC) #1
hshi1
lgtm
6 years, 10 months ago (2014-02-13 23:46:50 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 10 months ago (2014-02-13 23:47:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
6 years, 10 months ago (2014-02-13 23:51:35 UTC) #4
pkotwicz
https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/workspace_layout_manager.cc File ash/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/workspace_layout_manager.cc#newcode129 ash/wm/workspace/workspace_layout_manager.cc:129: SetMaximizedOrFullscreenBounds(window_state); Optional Nit: You could modify the implementation of ...
6 years, 10 months ago (2014-02-14 00:22:26 UTC) #5
oshima
https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/workspace_layout_manager.cc File ash/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/workspace_layout_manager.cc#newcode129 ash/wm/workspace/workspace_layout_manager.cc:129: SetMaximizedOrFullscreenBounds(window_state); On 2014/02/14 00:22:26, pkotwicz wrote: > Optional Nit: ...
6 years, 10 months ago (2014-02-14 00:42:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 01:50:24 UTC) #7
commit-bot: I haz the power
List of reviewers changed. pkotwicz@chromium.org did a drive-by without LGTM'ing!
6 years, 10 months ago (2014-02-14 01:50:24 UTC) #8
hshi1
The CQ bit was checked by hshi@chromium.org
6 years, 10 months ago (2014-02-14 01:50:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
6 years, 10 months ago (2014-02-14 01:52:12 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 04:09:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-14 04:09:52 UTC) #12
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 10 months ago (2014-02-14 04:17:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
6 years, 10 months ago (2014-02-14 04:19:28 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 05:17:29 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-14 05:17:30 UTC) #16
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-14 05:43:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
6 years, 10 months ago (2014-02-14 05:44:31 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:53:39 UTC) #19
Message was sent while issue was closed.
Change committed as 251313

Powered by Google App Engine
This is Rietveld 408576698