|
|
Created:
6 years, 10 months ago by oshima Modified:
6 years, 10 months ago CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, pkotwicz Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionPut the logic to maximize/fullscreen window back in OnWindowAddedToLayout
I'll look into if we can eliminate this.
BUG=343696
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251313
Patch Set 1 : #
Total comments: 2
Messages
Total messages: 19 (0 generated)
lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/worksp... File ash/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/worksp... ash/wm/workspace/workspace_layout_manager.cc:129: SetMaximizedOrFullscreenBounds(window_state); Optional Nit: You could modify the implementation of AdjustWindowBoundsWhenAdded() given that it is only invoked from here
https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/worksp... File ash/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/165273002/diff/100001/ash/wm/workspace/worksp... ash/wm/workspace/workspace_layout_manager.cc:129: SetMaximizedOrFullscreenBounds(window_state); On 2014/02/14 00:22:26, pkotwicz wrote: > Optional Nit: You could modify the implementation of > AdjustWindowBoundsWhenAdded() given that it is only invoked from here Thanks, I'll clean up in separate CL with tests coverage.
The CQ bit was unchecked by commit-bot@chromium.org
List of reviewers changed. pkotwicz@chromium.org did a drive-by without LGTM'ing!
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/165273002/100001
Message was sent while issue was closed.
Change committed as 251313 |