Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: ash/wm/workspace/workspace_layout_manager.cc

Issue 165273002: Put the logic to maximize/fullscreen window back in OnWindowAddedToLayout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_layout_manager.cc
diff --git a/ash/wm/workspace/workspace_layout_manager.cc b/ash/wm/workspace/workspace_layout_manager.cc
index efe6c6803514ec5f40897ba0f5c33cd045b9a1a8..0f9c8f7fdab3eef3fd09694b64a9eec228e6451a 100644
--- a/ash/wm/workspace/workspace_layout_manager.cc
+++ b/ash/wm/workspace/workspace_layout_manager.cc
@@ -122,6 +122,11 @@ void WorkspaceLayoutManager::OnWindowAddedToLayout(Window* child) {
windows_.insert(child);
child->AddObserver(this);
window_state->AddObserver(this);
+ // TODO(oshima): This is necessary as the call in
+ // AdjustWindowBoundsWhenAdded is skipped when the bounds is
+ // empty. Investigate if we can eliminate this dup.
+ if (!window_state->is_dragged())
+ SetMaximizedOrFullscreenBounds(window_state);
pkotwicz 2014/02/14 00:22:26 Optional Nit: You could modify the implementation
oshima 2014/02/14 00:42:49 Thanks, I'll clean up in separate CL with tests co
UpdateShelfVisibility();
UpdateFullscreenState();
WindowPositioner::RearrangeVisibleWindowOnShow(child);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698