Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1652543003: Merge to XFA: Add tests for CBA_AnnotIterator. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add tests for CBA_AnnotIterator. Original Review URL: https://codereview.chromium.org/1652533002 . (cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fe351dbc18e419b0ed9fbe34f2d1fb155b4f7bf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 4 chunks +6 lines, -11 lines 0 comments Download
A fpdfsdk/src/fsdk_baseform_embeddertest.cpp View 1 chunk +115 lines, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A testing/resources/annotiter.in View 1 chunk +129 lines, -0 lines 0 comments Download
A testing/resources/annotiter.pdf View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR
4 years, 10 months ago (2016-01-30 00:21:31 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as fe351dbc18e419b0ed9fbe34f2d1fb155b4f7bf1 (presubmit successful).
4 years, 10 months ago (2016-01-30 00:26:30 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-01-30 00:29:20 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698