Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652533002: Add tests for CBA_AnnotIterator. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for CBA_AnnotIterator. I'm about to replace the sort() that underlies this class, so I first want to be sure I don't disrupt the order. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3

Patch Set 1 #

Total comments: 3

Patch Set 2 : Expose FromFPDFFormHandle(). #

Patch Set 3 : Nit. #

Total comments: 1

Patch Set 4 : static_cast. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 4 chunks +6 lines, -11 lines 0 comments Download
A fpdfsdk/src/fsdk_baseform_embeddertest.cpp View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A testing/resources/annotiter.in View 1 chunk +129 lines, -0 lines 0 comments Download
A testing/resources/annotiter.pdf View 1 2 3 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Tom Sepez
For review.
4 years, 10 months ago (2016-01-29 23:25:06 UTC) #1
Lei Zhang
https://codereview.chromium.org/1652533002/diff/1/fpdfsdk/src/fsdk_baseform_embeddertest.cpp File fpdfsdk/src/fsdk_baseform_embeddertest.cpp (right): https://codereview.chromium.org/1652533002/diff/1/fpdfsdk/src/fsdk_baseform_embeddertest.cpp#newcode23 fpdfsdk/src/fsdk_baseform_embeddertest.cpp:23: } // Namespace. just "namespace" https://codereview.chromium.org/1652533002/diff/1/testing/embedder_test.cpp File testing/embedder_test.cpp (right): ...
4 years, 10 months ago (2016-01-29 23:39:23 UTC) #2
Tom Sepez
https://codereview.chromium.org/1652533002/diff/1/testing/embedder_test.cpp File testing/embedder_test.cpp (right): https://codereview.chromium.org/1652533002/diff/1/testing/embedder_test.cpp#newcode97 testing/embedder_test.cpp:97: reinterpret_cast<CPDFDoc_Environment*>(form_handle_); On 2016/01/29 23:39:23, Lei Zhang wrote: > Can ...
4 years, 10 months ago (2016-01-29 23:55:48 UTC) #3
Tom Sepez
PS#3 for review.
4 years, 10 months ago (2016-01-30 00:09:35 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1652533002/diff/40001/fpdfsdk/src/fsdk_mgr.cpp File fpdfsdk/src/fsdk_mgr.cpp (right): https://codereview.chromium.org/1652533002/diff/40001/fpdfsdk/src/fsdk_mgr.cpp#newcode384 fpdfsdk/src/fsdk_mgr.cpp:384: CPDFDoc_Environment* pEnv = (CPDFDoc_Environment*)hHandle; Remove C-style cast?
4 years, 10 months ago (2016-01-30 00:15:15 UTC) #5
Tom Sepez
On 2016/01/30 00:15:15, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1652533002/diff/40001/fpdfsdk/src/fsdk_mgr.cpp > File fpdfsdk/src/fsdk_mgr.cpp (right): ...
4 years, 10 months ago (2016-01-30 00:16:14 UTC) #6
Tom Sepez
4 years, 10 months ago (2016-01-30 00:18:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698