Browser Side Text Input State Tracking for OOPIF.

content/browser/frame_host/interstitial_page_impl.cc

Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index 4d071e3c39eed2d5d34834299dfeb2c3fa2c2e23..a0cfaa94fac55e01fcd5cd8aa386b8f2864e336f 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -537,6 +537,20 @@ void InterstitialPageImpl::RenderWidgetDeleted(
   CHECK(!web_contents_);
 }
 
+TextInputState InterstitialPageImpl::GetTextInputState() {
+  if (web_contents_)

[Charlie Reis, 2016/03/15 18:32:00]

Style nit: Body is more than one line, so this needs braces.  Same below.

[EhsanK, 2016/03/15 23:51:17]

Fit in one line after 'git cl format'. Thanks!

+    text_input_state_ = static_cast<WebContentsImpl*>(web_contents_)
+                         ->GetTextInputState();
+  return TextInputState();

[Charlie Reis, 2016/03/15 18:32:00]

Is this a bug?  Looks like we assign a value to text_input_state_ but never use
it.  (What's the reason for caching it in InterstitialPageImpl?)

[EhsanK, 2016/03/15 23:51:17]

Definitely a bug and surprised why tests didn't fail. It was left over when I
patched and uploaded from a draft CL
(https://codereview.chromium.org/1663013005/).

Thanks for noticing this.

+}
+
+void InterstitialPageImpl::UpdateTextInputState(RenderWidgetHostViewBase* rwhv,
+                                                bool text_input_state_changed) {
+  if (web_contents_)
+    return static_cast<WebContentsImpl*>(web_contents_)
+                      ->UpdateTextInputState(rwhv, text_input_state_changed);
+}
+
 bool InterstitialPageImpl::PreHandleKeyboardEvent(
     const NativeWebKeyboardEvent& event,
     bool* is_keyboard_shortcut) {