Browser Side Text Input State Tracking for OOPIF.

content/browser/frame_host/interstitial_page_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 519 matching lines @@
   delegate_->OverrideRendererPrefs(&renderer_preferences_);
   return renderer_preferences_;
 }
 
 void InterstitialPageImpl::RenderWidgetDeleted(
     RenderWidgetHostImpl* render_widget_host) {
   // TODO(creis): Remove this method once we verify the shutdown path is sane.
   CHECK(!web_contents_);
 }
 
+TextInputState InterstitialPageImpl::GetTextInputState() {
+  if (web_contents_)

[Charlie Reis, 2016/03/15 18:32:00]

Style nit: Body is more than one line, so this needs braces.  Same below.

[EhsanK, 2016/03/15 23:51:17]

Fit in one line after 'git cl format'. Thanks!

+    text_input_state_ = static_cast<WebContentsImpl*>(web_contents_)
+                         ->GetTextInputState();
+  return TextInputState();

[Charlie Reis, 2016/03/15 18:32:00]

Is this a bug?  Looks like we assign a value to text_input_state_ but never use
it.  (What's the reason for caching it in InterstitialPageImpl?)

[EhsanK, 2016/03/15 23:51:17]

Definitely a bug and surprised why tests didn't fail. It was left over when I
patched and uploaded from a draft CL
(https://codereview.chromium.org/1663013005/).

Thanks for noticing this.

+}
+
+void InterstitialPageImpl::UpdateTextInputState(RenderWidgetHostViewBase* rwhv,
+                                                bool text_input_state_changed) {
+  if (web_contents_)
+    return static_cast<WebContentsImpl*>(web_contents_)
+                      ->UpdateTextInputState(rwhv, text_input_state_changed);
+}
+
 bool InterstitialPageImpl::PreHandleKeyboardEvent(
     const NativeWebKeyboardEvent& event,
     bool* is_keyboard_shortcut) {
   if (!enabled())
     return false;
   return render_widget_host_delegate_->PreHandleKeyboardEvent(
       event, is_keyboard_shortcut);
 }
 
 void InterstitialPageImpl::HandleKeyboardEvent(
@@ skipping 385 matching lines @@
 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
     const LoadCommittedDetails& load_details) {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 }  // namespace content