Issue 165236: Enable remote fonts by default

Issue 165236: Enable remote fonts by default (Closed)

Created:
11 years, 4 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews_googlegroups.com, darin (slow to review), tony, taviso1, agl

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable remote fonts by default. This change introduces --disable-remote-fonts flag and obsoletes --enable-remote-fonts. BUG=17818 TEST=(1) Start chromium WITHOUT --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _remote_ fonts (reference image: http://www.alistapart.com/d/cssatten/poen.png ) / (2) Start chromium WITH --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _local_ fonts Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33800

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
	chrome/common/chrome_switches.h	View	2 3 4 5 6 7	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 3 4 5 6 7	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Jungshik, can you please review this CL as well? I don't submit this change unless ...

11 years, 1 month ago (2009-11-04 11:04:49 UTC) #1

jungshik at Google

Yusuke, I think we don't want to add a pref. entry for this. See the ...

11 years, 1 month ago (2009-11-04 21:15:20 UTC) #2

Yusuke Sato

Ah, I see. Thanks. Fixed. On 2009/11/04 21:15:20, Jungshik Shin wrote: > Yusuke, > > ...

11 years, 1 month ago (2009-11-05 05:39:21 UTC) #3

jungshik at Google

lgtm ! On 2009/11/05 05:39:21, Yusuke Sato wrote: > Ah, I see. Thanks. > Fixed. ...

11 years, 1 month ago (2009-11-05 08:19:40 UTC) #4

Yusuke Sato

11 years ago (2009-12-04 05:45:57 UTC) #5

OTS glue has been (finally) submitted to WebKit trunk (r51623) and WebKit DEPS
roll has done. I'll submit this change soon.

--Yusuke

On 2009/11/05 08:19:40, Jungshik Shin wrote:
> lgtm !
> 
> On 2009/11/05 05:39:21, Yusuke Sato wrote:
> > Ah, I see. Thanks.
> > Fixed.
> > 
> > On 2009/11/04 21:15:20, Jungshik Shin wrote:
> > > Yusuke,
> > > 
> > > I think we don't want to add a pref. entry for this. See the review
comment
> by
> > > Tony for my CL to add '--enable-remote-font'  at
> > > http://codereview.chromium.org/67210

Expand Messages | Collapse Messages