Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 67210: Chrome-part of disabling web fonts by default. ... (Closed)

Created:
11 years, 8 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, Mark Larson, dglazkov
Visibility:
Public.

Description

Chrome-part of disabling web fonts by default while still alowing SVG fonts (The webkit part is http://codereview.chromium.org/67209/show and http://bugs.webkit.org/show_bug.cgi?id=25239 ) 1. Adds '--enable-remote-fonts' command line switch 2. Adds a field ('enable_remote_fonts) to WebPreference 3. Pass the value of enable_remote_fonts to the corresponding field in WebCore::Settings (m_downloadableBinaryFontsEnabled) BUG=9633 TEST: 1. Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts. 2. Even without the above flag, Chrome should should get 100/100, with no boxes in the upper right corner (still has the Linktest Failed error). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16247

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M DEPS View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jungshik at Google
11 years, 8 months ago (2009-04-16 06:48:06 UTC) #1
jungshik at Google
This is a Chrome-side companion to http://codereview.chromium.org/67209/show (Webkit change) to use in the 2.0 branch.
11 years, 8 months ago (2009-04-17 22:44:45 UTC) #2
tony
I agree with brett. Do we need a value in pref_names for this? There's no ...
11 years, 8 months ago (2009-04-17 22:51:35 UTC) #3
jungshik at Google
Hmm. why did I miss this reply? :-) As for the pref entry, I debated ...
11 years, 8 months ago (2009-04-21 17:27:01 UTC) #4
jungshik at Google
Patch updated. Can you take another look? On 2009/04/21 17:27:01, Jungshik Shin wrote: > Hmm. ...
11 years, 8 months ago (2009-04-21 20:36:11 UTC) #5
tony
11 years, 8 months ago (2009-04-21 21:03:27 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698