Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 165223002: rAc: minimal crash fix for bug 342990. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 827468a8067e3b1580d21846ad9c2f79db6fd5c0..001c05ea0c2e5f02405730239230ba8d323ca367 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -2210,6 +2210,10 @@ void AutofillDialogViews::InputEditedOrActivated(ServerFieldType type,
DecoratedTextfield* decorated = TextfieldForType(type);
views::Combobox* combobox = ComboboxForType(type);
DCHECK_NE(!!combobox, !!decorated);
+
+ if (!combobox && !decorated)
Evan Stade 2014/02/14 22:26:11 this is fine, but please put the DCHECK_NE below t
Dan Beam 2014/02/14 22:47:35 Done.
+ return;
+
DetailsGroup* group = decorated ? GroupForView(decorated) :
GroupForView(combobox);
base::string16 text = decorated ?
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698