rAc: minimal crash fix for bug 342990.

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 2192 matching lines @@
 }
 
 void AutofillDialogViews::InputEditedOrActivated(ServerFieldType type,
                                                  const gfx::Rect& bounds,
                                                  bool was_edit) {
   DCHECK_NE(UNKNOWN_TYPE, type);
 
   DecoratedTextfield* decorated = TextfieldForType(type);
   views::Combobox* combobox = ComboboxForType(type);
   DCHECK_NE(!!combobox, !!decorated);
+
+  if (!combobox && !decorated)

[Evan Stade, 2014/02/14 22:26:11]

this is fine, but please put the DCHECK_NE below this if, and put a comment that
says something like "Both views may be null if the event may come from an
inactive section, which may occur when using an IME."

[Dan Beam, 2014/02/14 22:47:35]

Done.

+    return;
+
   DetailsGroup* group = decorated ? GroupForView(decorated) :
                                     GroupForView(combobox);
   base::string16 text = decorated ?
       decorated->text() :
       combobox->model()->GetItemAt(combobox->selected_index());
   DCHECK(group);
 
   delegate_->UserEditedOrActivatedInput(group->section,
                                         type,
                                         GetWidget()->GetNativeView(),
@@ skipping 219 matching lines @@
 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
     : section(section),
       container(NULL),
       manual_input(NULL),
       suggested_info(NULL),
       suggested_button(NULL) {}
 
 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
 
 }  // namespace autofill