Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165223002: rAc: minimal crash fix for bug 342990. (Closed)

Created:
6 years, 10 months ago by Dan Beam
Modified:
6 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: minimal crash fix for bug 342990. BUG=342990 TEST=no more crashes R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251517

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dan Beam
if you're really worried about this crash, this is an option
6 years, 10 months ago (2014-02-13 23:29:42 UTC) #1
Evan Stade
https://codereview.chromium.org/165223002/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/165223002/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode2214 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:2214: if (!combobox && !decorated) this is fine, but please ...
6 years, 10 months ago (2014-02-14 22:26:11 UTC) #2
Dan Beam
https://codereview.chromium.org/165223002/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/165223002/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode2214 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:2214: if (!combobox && !decorated) On 2014/02/14 22:26:11, Evan Stade ...
6 years, 10 months ago (2014-02-14 22:47:35 UTC) #3
Evan Stade
lgtm
6 years, 10 months ago (2014-02-14 23:07:37 UTC) #4
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 10 months ago (2014-02-14 23:07:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/165223002/120001
6 years, 10 months ago (2014-02-14 23:23:44 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 04:48:58 UTC) #7
Message was sent while issue was closed. 
Change committed as 251517

Powered by Google App Engine
This is Rietveld 408576698