Resynthesize top-level and class static property access references.

Resynthesize top-level and class static property access references.

Class static methods have some complications related to propagated
types, so I will do it after this CL.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a568af080edaf4c9479992d8dd3f2cfc3920c6ab

[Paul Berry, 2016-02-01 19:27:17]

lgtm

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:420: Identifier node =
_buildElementAst(info.name, info.type.element);
I bet this case (info.element == null but info.type != null) is only necessary
to handle `dynamic`.  Consider changing populateReferenceInfos() so that it just
populates the element appropriately in the case of `dynamic`, and then I think
we could just drop this case entirely.

Or if you'd rather let me experiment with that in a follow CL, let me know and
I'll take care of it.

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:256:
compareConstantExpressions(r, o.propertyName, desc);
What about the case of:

    const x = 'foo';
    const y = x.length;

Will `const y` get tested correctly?  (In this case we need to verify that it
really gets resynthesized as a prefixed identifier or a property access, so that
constant evaluation will be able to see that the thing we're taking the length
of is `x`).

[scheglov, 2016-02-01 19:42:19]

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:420: Identifier node =
_buildElementAst(info.name, info.type.element);
On 2016/02/01 19:27:16, Paul Berry wrote:
> I bet this case (info.element == null but info.type != null) is only necessary
> to handle `dynamic`.  Consider changing populateReferenceInfos() so that it
just
> populates the element appropriately in the case of `dynamic`, and then I think
> we could just drop this case entirely.
> 
> Or if you'd rather let me experiment with that in a follow CL, let me know and
> I'll take care of it.

I will try to simplify this in the next CL.

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1652183002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:256:
compareConstantExpressions(r, o.propertyName, desc);
On 2016/02/01 19:27:17, Paul Berry wrote:
> What about the case of:
> 
>     const x = 'foo';
>     const y = x.length;
> 
> Will `const y` get tested correctly?  (In this case we need to verify that it
> really gets resynthesized as a prefixed identifier or a property access, so
that
> constant evaluation will be able to see that the thing we're taking the length
> of is `x`).

We don't support 'length' resynthesizing yet.

[scheglov, 2016-02-01 19:43:21]

Description was changed from

==========
Resynthesize top-level and class static property access references.

Class static methods have some complications related to propagated
types, so I will do it after this CL.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize top-level and class static property access references.

Class static methods have some complications related to propagated
types, so I will do it after this CL.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a568af080edaf4c9479992d8dd3f2cfc3920c6ab
==========

[scheglov, 2016-02-01 19:43:23]

Committed patchset #1 (id:1) manually as
a568af080edaf4c9479992d8dd3f2cfc3920c6ab (presubmit successful).