Resynthesize top-level and class static property access references.

pkg/analyzer/test/src/summary/resynthesize_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/element.dart';
@@ skipping 228 matching lines @@
       compareTypes(r.staticType, o.staticType, desc);
       if (o is ParenthesizedExpression) {
         // We don't resynthesize parenthesis, so just ignore it.
         compareConstantExpressions(r, o.expression, desc);
       } else if (o is SimpleIdentifier && r is SimpleIdentifier) {
         expect(r.name, o.name);
         compareElements(r.staticElement, o.staticElement, desc);
         // ConstantAstCloner does not copy static types, and constant values
         // computer does not use static types. So, we don't set them during
         // resynthesis and should not check them.
-      } else if (o is PrefixedIdentifier) {
+      } else if (o is PrefixedIdentifier && r is SimpleIdentifier) {
         // We don't resynthesize prefixed identifiers.
-        // We use simple identifiers with correct elements and types.
-        compareConstantExpressions(r as SimpleIdentifier, o.identifier, desc);
+        // We use simple identifiers with correct elements.
+        compareConstantExpressions(r, o.identifier, desc);
+      } else if (o is PropertyAccess && r is SimpleIdentifier) {
+        // We don't resynthesize property access.
+        // We use simple identifiers with correct elements.
+        compareConstantExpressions(r, o.propertyName, desc);

[Paul Berry, 2016/02/01 19:27:17]

What about the case of:

    const x = 'foo';
    const y = x.length;

Will `const y` get tested correctly?  (In this case we need to verify that it
really gets resynthesized as a prefixed identifier or a property access, so that
constant evaluation will be able to see that the thing we're taking the length
of is `x`).

[scheglov, 2016/02/01 19:42:18]

We don't support 'length' resynthesizing yet.

       } else if (o is NullLiteral) {
         expect(r, new isInstanceOf<NullLiteral>(), reason: desc);
       } else if (o is BooleanLiteral && r is BooleanLiteral) {
         expect(r.value, o.value, reason: desc);
       } else if (o is IntegerLiteral && r is IntegerLiteral) {
         expect(r.value, o.value, reason: desc);
       } else if (o is DoubleLiteral && r is DoubleLiteral) {
         expect(r.value, o.value, reason: desc);
       } else if (o is StringInterpolation && r is StringInterpolation) {
         compareLists(r.elements, o.elements);
@@ skipping 740 matching lines @@
   }
 
   test_class_type_parameters_f_bound_simple() {
     checkLibrary('class C<T extends U, U> {}');
   }
 
   test_classes() {
     checkLibrary('class C {} class D {}');
   }
 
+  test_const_reference_staticField() {
+    shouldCompareConstValues = true;
+    checkLibrary(r'''
+class C {
+  static const int F = 42;
+}
+const V = C.F;
+''');
+  }
+
+  test_const_reference_staticField_imported() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+class C {
+  static const int F = 42;
+}
+''');
+    checkLibrary(r'''
+import 'a.dart';
+const V = C.F;
+''');
+  }
+
+  test_const_reference_staticField_imported_withPrefix() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+class C {
+  static const int F = 42;
+}
+''');
+    checkLibrary(r'''
+import 'a.dart' as p;
+const V = p.C.F;
+''');
+  }
+
+  test_const_reference_topLevelVariable() {
+    shouldCompareConstValues = true;
+    checkLibrary(r'''
+const A = 1;
+const B = A + 2;
+''');
+  }
+
+  test_const_reference_topLevelVariable_imported() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+const A = 1;
+''');
+    checkLibrary(r'''
+import 'a.dart';
+const B = A + 2;
+''');
+  }
+
+  test_const_reference_topLevelVariable_imported_withPrefix() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+const A = 1;
+''');
+    checkLibrary(r'''
+import 'a.dart' as p;
+const B = p.A + 2;
+''');
+  }
+
   test_const_reference_type() {
     shouldCompareConstValues = true;
     checkLibrary(r'''
 class C {}
 class D<T> {}
 enum E {a, b, c}
 typedef F(int a, String b);
 const vDynamic = dynamic;
 const vNull = Null;
 const vObject = Object;
@@ skipping 1110 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }