Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652133003: Fix non-Latin key event handling for menu mnemonics (Closed)

Created:
4 years, 10 months ago by mohsen
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-Latin key event handling for menu mnemonics BUG=564255, 582555 Committed: https://crrev.com/66f50590116332a7d4cbda9e4eaae81b1274944c Cr-Commit-Position: refs/heads/master@{#372987}

Patch Set 1 #

Patch Set 2 : Added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -6 lines) Patch
M ui/views/controls/menu/menu_key_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_unittest.cc View 1 5 chunks +62 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 769393002 Patch 1

Messages

Total messages: 9 (4 generated)
mohsen
Please take a look...
4 years, 10 months ago (2016-02-02 16:21:09 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-02 18:01:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652133003/20001
4 years, 10 months ago (2016-02-02 18:07:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 18:16:00 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 18:16:53 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/66f50590116332a7d4cbda9e4eaae81b1274944c
Cr-Commit-Position: refs/heads/master@{#372987}

Powered by Google App Engine
This is Rietveld 408576698