Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: ui/views/controls/menu/menu_key_event_handler.cc

Issue 1652133003: Fix non-Latin key event handling for menu mnemonics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/menu/menu_runner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_key_event_handler.cc
diff --git a/ui/views/controls/menu/menu_key_event_handler.cc b/ui/views/controls/menu/menu_key_event_handler.cc
index c751c4c4f7d75899d58823a7f3f65ab4c7c345c1..af0566e2af93833c5704f9d2a18d8d0d64df33ba 100644
--- a/ui/views/controls/menu/menu_key_event_handler.cc
+++ b/ui/views/controls/menu/menu_key_event_handler.cc
@@ -57,7 +57,7 @@ void MenuKeyEventHandler::OnKeyEvent(ui::KeyEvent* event) {
const int flags = event->flags();
if (menu_controller->exit_type() == MenuController::EXIT_NONE &&
(flags & kKeyFlagsMask) == 0) {
- char c = event->GetCharacter();
+ base::char16 c = event->GetCharacter();
menu_controller->SelectByChar(c);
// Menu controller might have been deleted.
if (!MenuController::GetActiveInstance())
« no previous file with comments | « no previous file | ui/views/controls/menu/menu_runner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698