Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1652083004: Merge to XFA: Remove the m_V5Type member variable from CPDF_Parser. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove the m_V5Type member variable from CPDF_Parser. Use the type field in the m_ObjectInfo map instead. BUG=pdfium:111 TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1650793002 . (cherry picked from commit 93c196d868535f684007a7d3ed1f7146851a0ab9) Committed: https://pdfium.googlesource.com/pdfium/+/cb3a0557e7cbb205d1415969033ce3874a2bd3d8

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -46 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 21 chunks +28 lines, -34 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR, clean merge.
4 years, 10 months ago (2016-02-01 21:42:57 UTC) #1
Lei Zhang
Committed patchset #3 (id:40001) manually as cb3a0557e7cbb205d1415969033ce3874a2bd3d8 (presubmit successful).
4 years, 10 months ago (2016-02-01 21:45:34 UTC) #3
Wei Li
4 years, 10 months ago (2016-02-01 22:08:17 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698