Issue 1652083004: Merge to XFA: Remove the m_V5Type member variable from CPDF_Parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1652083004: Merge to XFA: Remove the m_V5Type member variable from CPDF_Parser. (Closed)

Created:
4 years, 10 months ago by Lei Zhang

Modified:
4 years, 10 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove the m_V5Type member variable from CPDF_Parser. Use the type field in the m_ObjectInfo map instead. BUG=pdfium:111 TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1650793002 . (cherry picked from commit 93c196d868535f684007a7d3ed1f7146851a0ab9) Committed: https://pdfium.googlesource.com/pdfium/+/cb3a0557e7cbb205d1415969033ce3874a2bd3d8

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -46 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	21 chunks	+28 lines, -34 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View	4 chunks	+12 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

Committed patchset #3 (id:40001) manually as cb3a0557e7cbb205d1415969033ce3874a2bd3d8 (presubmit successful).

4 years, 10 months ago (2016-02-01 21:45:34 UTC) #3

Message was sent while issue was closed.

lgtm