Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1650793002: Remove the m_V5Type member variable from CPDF_Parser. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the m_V5Type member variable from CPDF_Parser. Use the type field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/93c196d868535f684007a7d3ed1f7146851a0ab9

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -46 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 21 chunks +28 lines, -34 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
https://codereview.chromium.org/1650793002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1650793002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode345 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:345: if (GetObjectType(objnum) == 1) I should have done more ...
4 years, 10 months ago (2016-01-30 03:38:43 UTC) #1
Wei Li
lgtm
4 years, 10 months ago (2016-02-01 17:43:34 UTC) #2
Lei Zhang
4 years, 10 months ago (2016-02-01 21:36:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
93c196d868535f684007a7d3ed1f7146851a0ab9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698