Issue 165196: Merge 22195 - Do not abort the process if thread owning the log mutex has cra...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165196: Merge 22195 - Do not abort the process if thread owning the log mutex has cra... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 22195 - Do not abort the process if thread owning the log mutex has crashed. It makes UI tests even more flaky. However, we still log that event. TEST=none http://crbug.com/18028 Review URL: http://codereview.chromium.org/159723 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22844

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	MM	base/logging.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

11 years, 4 months ago (2009-08-10 16:07:18 UTC) #2

LGTM, but please merge also http://codereview.chromium.org/159789
(http://src.chromium.org/viewvc/chrome?view=rev&revision=22292).