Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Unified Diff: base/logging.cc

Issue 165196: Merge 22195 - Do not abort the process if thread owning the log mutex has cra... (Closed) Base URL: svn://chrome-svn/chrome/branches/195/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
===================================================================
--- base/logging.cc (revision 22843)
+++ base/logging.cc (working copy)
@@ -485,7 +485,12 @@
#if defined(OS_WIN)
DWORD r = ::WaitForSingleObject(log_mutex, INFINITE);
- DCHECK(r != WAIT_ABANDONED);
+ if (r == WAIT_ABANDONED) {
+ // Do not abort the process here. UI tests might be crashy sometimes,
+ // and aborting the test binary only makes the problem worse.
+ // For more info see http://crbug.com/18028.
+ LOG(ERROR) << "Thread owning the log mutex has crashed.";
+ }
#elif defined(OS_POSIX)
pthread_mutex_lock(&log_mutex);
#endif
Property changes on: base\logging.cc
___________________________________________________________________
Added: svn:mergeinfo
Merged /branches/chrome_webkit_merge_branch/base/logging.cc:r69-2775
Merged /trunk/src/base/logging.cc:r22195
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698