Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 165194: GTK: Use stock icons for bookmark folder and default favicon.... (Closed)

Created:
11 years, 4 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

GTK: Use stock icons for bookmark folder and default favicon. In the main window, in the default theme, we still use the chrome icons. There are still several more places that need updating: the tab strip, the task manager, etc. I will deal with that later. BUG=13320 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -29 lines) Patch
M chrome/browser/gtk/bookmark_editor_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_manager_gtk.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_tree_model.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_utils_gtk.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/gtk/bookmark_utils_gtk.cc View 3 chunks +40 lines, -14 lines 0 comments Download
M chrome/browser/gtk/list_store_favicon_loader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/list_store_favicon_loader.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
11 years, 4 months ago (2009-08-08 00:52:50 UTC) #1
Elliot Glaysher
11 years, 4 months ago (2009-08-08 01:02:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698