Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: chrome/browser/gtk/bookmark_tree_model.cc

Issue 165194: GTK: Use stock icons for bookmark folder and default favicon.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/bookmark_manager_gtk.cc ('k') | chrome/browser/gtk/bookmark_utils_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_tree_model.cc
===================================================================
--- chrome/browser/gtk/bookmark_tree_model.cc (revision 22744)
+++ chrome/browser/gtk/bookmark_tree_model.cc (working copy)
@@ -16,10 +16,14 @@
void AddSingleNodeToTreeStore(GtkTreeStore* store, const BookmarkNode* node,
GtkTreeIter *iter, GtkTreeIter* parent) {
gtk_tree_store_append(store, iter, parent);
- // TODO(estade): we should show the folder open icon when it's expanded.
+ // It would be easy to show a different icon when the folder is open (as they
+ // do on Windows, for example), using pixbuf-expander-closed and
+ // pixbuf-expander-open. Unfortunately there is no GTK_STOCK_OPEN_DIRECTORY
+ // (and indeed, Nautilus does not render an expanded directory any
+ // differently).
gtk_tree_store_set(store, iter,
bookmark_utils::FOLDER_ICON,
- bookmark_utils::GetFolderIcon(),
+ bookmark_utils::GetFolderIcon(true),
bookmark_utils::FOLDER_NAME,
WideToUTF8(node->GetTitle()).c_str(),
bookmark_utils::ITEM_ID, node->id(),
« no previous file with comments | « chrome/browser/gtk/bookmark_manager_gtk.cc ('k') | chrome/browser/gtk/bookmark_utils_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698