Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2816)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 1651913003: Handle origin-specific password deletion in BrowsingDataRemover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments; switch to checking GURL emptiness for origin-based deletion. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index c54c63c32eb40b5d45fdf7150683c24a718223ec..a8f96ee6f5c8f900061d166323bc44c93bf9c3c3 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -291,12 +291,12 @@ class BrowsingDataRemover : public KeyedService
#endif
// Removes the specified items related to browsing for a specific host. If the
- // provided |remove_url| is empty, data is removed for all origins. The
+ // provided |remove_url| is empty, data is removed for all origins; otherwise,
+ // it is restricted by origin (where implemented yet). The
// |origin_type_mask| parameter defines the set of origins from which data
// should be removed (protected, unprotected, or both).
- // TODO(mkwst): The current implementation relies on unique (empty) origins to
- // signal removal of all origins. Reconsider this behavior if/when we build
- // a "forget this site" feature.
+ // TODO(ttr314): Remove "(where implemented yet)" constraint above once
+ // crbug.com/113621 is done.
void RemoveImpl(const TimeRange& time_range,
int remove_mask,
const GURL& remove_url,
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698