Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 1651913003: Handle origin-specific password deletion in BrowsingDataRemover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments; switch to checking GURL emptiness for origin-based deletion. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 void OnDeauthorizeContentLicensesCompleted(uint32_t request_id, 284 void OnDeauthorizeContentLicensesCompleted(uint32_t request_id,
285 bool success) override; 285 bool success) override;
286 #endif 286 #endif
287 287
288 #if defined (OS_CHROMEOS) 288 #if defined (OS_CHROMEOS)
289 void OnClearPlatformKeys(chromeos::DBusMethodCallStatus call_status, 289 void OnClearPlatformKeys(chromeos::DBusMethodCallStatus call_status,
290 bool result); 290 bool result);
291 #endif 291 #endif
292 292
293 // Removes the specified items related to browsing for a specific host. If the 293 // Removes the specified items related to browsing for a specific host. If the
294 // provided |remove_url| is empty, data is removed for all origins. The 294 // provided |remove_url| is empty, data is removed for all origins; otherwise,
295 // it is restricted by origin (where implemented yet). The
295 // |origin_type_mask| parameter defines the set of origins from which data 296 // |origin_type_mask| parameter defines the set of origins from which data
296 // should be removed (protected, unprotected, or both). 297 // should be removed (protected, unprotected, or both).
297 // TODO(mkwst): The current implementation relies on unique (empty) origins to 298 // TODO(ttr314): Remove "(where implemented yet)" constraint above once
298 // signal removal of all origins. Reconsider this behavior if/when we build 299 // crbug.com/113621 is done.
299 // a "forget this site" feature.
300 void RemoveImpl(const TimeRange& time_range, 300 void RemoveImpl(const TimeRange& time_range,
301 int remove_mask, 301 int remove_mask,
302 const GURL& remove_url, 302 const GURL& remove_url,
303 int origin_type_mask); 303 int origin_type_mask);
304 304
305 // Notifies observers and transitions to the idle state. 305 // Notifies observers and transitions to the idle state.
306 void Notify(); 306 void Notify();
307 307
308 // Checks if we are all done, and if so, calls Notify(). 308 // Checks if we are all done, and if so, calls Notify().
309 void NotifyIfDone(); 309 void NotifyIfDone();
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 460
461 // We do not own this. 461 // We do not own this.
462 content::StoragePartition* storage_partition_for_testing_ = nullptr; 462 content::StoragePartition* storage_partition_for_testing_ = nullptr;
463 463
464 base::WeakPtrFactory<BrowsingDataRemover> weak_ptr_factory_; 464 base::WeakPtrFactory<BrowsingDataRemover> weak_ptr_factory_;
465 465
466 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover); 466 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
467 }; 467 };
468 468
469 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 469 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698