Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3312)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/webdriver/webdriver_logging.cc

Issue 16519003: Define a LoggingSettings struct to use for InitLogging() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/chromedriver/server/chromedriver_server.cc ('K') | « chrome/test/chromedriver/server/chromedriver_server.cc ('k') | chrome/tools/crash_service/main.cc » ('j') | ui/views/examples/content_client/examples_main_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_logging.cc
diff --git a/chrome/test/webdriver/webdriver_logging.cc b/chrome/test/webdriver/webdriver_logging.cc
index 7a56f06484d2d1c088f173572782f4e094b27aa7..bd0de2253b262d37e8ecc66492f9a96d2a261ee4 100644
--- a/chrome/test/webdriver/webdriver_logging.cc
+++ b/chrome/test/webdriver/webdriver_logging.cc
@@ -228,12 +228,9 @@ bool InitWebDriverLogging(const base::FilePath& log_path,
LogLevel min_log_level) {
start_time = base::Time::Now().ToDoubleT();
// Turn off base/logging.
- bool success = InitLogging(
- NULL,
- logging::LOG_NONE,
- logging::DONT_LOCK_LOG_FILE,
- logging::DELETE_OLD_LOG_FILE,
- logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
+ logging::LoggingSettings settings;
+ settings.logging_dest = logging::LOG_NONE;
+ bool success = logging::InitLogging(settings);
sky 2013/06/19 23:22:28 Don't you lose DELETE_OLD_LOG_FILE here too?
akalin 2013/06/20 07:35:10 ditto (not logging to anything)
if (!success) {
PLOG(ERROR) << "Unable to initialize logging";
}
« chrome/test/chromedriver/server/chromedriver_server.cc ('K') | « chrome/test/chromedriver/server/chromedriver_server.cc ('k') | chrome/tools/crash_service/main.cc » ('j') | ui/views/examples/content_client/examples_main_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698