Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/server/chromedriver_server.cc

Issue 16519003: Define a LoggingSettings struct to use for InitLogging() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/gcapi/gcapi_dll.cc ('K') | « chrome/installer/util/logging_installer.cc ('k') | chrome/test/webdriver/webdriver_logging.cc » ('j') | chrome/test/webdriver/webdriver_logging.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/server/chromedriver_server.cc
diff --git a/chrome/test/chromedriver/server/chromedriver_server.cc b/chrome/test/chromedriver/server/chromedriver_server.cc
index f0c4afe522e10a7b50934a4264d859773ba61b87..b95da971612dd6fa03c4e103c716b813f9349ffe 100644
--- a/chrome/test/chromedriver/server/chromedriver_server.cc
+++ b/chrome/test/chromedriver/server/chromedriver_server.cc
@@ -144,12 +144,9 @@ int main(int argc, char *argv[]) {
}
}
- bool success = InitLogging(
- NULL,
- logging::LOG_ONLY_TO_SYSTEM_DEBUG_LOG,
- logging::DONT_LOCK_LOG_FILE,
- logging::DELETE_OLD_LOG_FILE,
- logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
+ logging::LoggingSettings settings;
+ settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
+ bool success = logging::InitLogging(settings);
sky 2013/06/19 23:22:28 Don't you lose DELETE_OLD_LOG_FILE?
akalin 2013/06/20 07:35:10 ditto
if (!success) {
PLOG(ERROR) << "Unable to initialize logging";
}
« chrome/installer/gcapi/gcapi_dll.cc ('K') | « chrome/installer/util/logging_installer.cc ('k') | chrome/test/webdriver/webdriver_logging.cc » ('j') | chrome/test/webdriver/webdriver_logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698