Add MediaCodecAudioDecoder implementation

media/base/decoder_buffer.h

Index: media/base/decoder_buffer.h
diff --git a/media/base/decoder_buffer.h b/media/base/decoder_buffer.h
index 9010eaa3172d655d59625d67728a4ccb272216ae..1ada4aa10b4a523572947fc6029a64f6134bbbd0 100644
--- a/media/base/decoder_buffer.h
+++ b/media/base/decoder_buffer.h
@@ -39,10 +39,12 @@ class MEDIA_EXPORT DecoderBuffer
   enum {
     kPaddingSize = 32,
 #if defined(ARCH_CPU_ARM_FAMILY)
-    kAlignmentSize = 16
+    kAlignmentSize = 16,
 #else
-    kAlignmentSize = 32
+    kAlignmentSize = 32,
 #endif
+    // A flag gor AsHumanReadableString()

[xhwang, 2016/02/05 21:37:36]

s/gor/for/

[Tima Vaisburd, 2016/02/06 03:54:11]

Deleted.

+    kShortFormat = 1,
   };
 
   // Allocates buffer with |size| >= 0.  Buffer will be padded and aligned
@@ -173,7 +175,7 @@ class MEDIA_EXPORT DecoderBuffer
   }
 
   // Returns a human-readable string describing |*this|.
-  std::string AsHumanReadableString();
+  std::string AsHumanReadableString(int flags = 0);

[xhwang, 2016/02/05 21:37:36]

|flags| is very ambiguous... I would like "bool verbose = false" more. Also that
can save an extra enum.

[Tima Vaisburd, 2016/02/06 03:54:11]

I humbly disagree. The usage ... << AsHumanReadableString(false)  ... would
stumble me (why false? what is false? ah, he meant short format..) and even if
you remember now that false means short soon you will wonder what this means
exactly. AsHumanReadableString(SHORT_FORMAT) is more descriptive.

Because of the disagreement let's revert this change, I can deal with long
format.

[xhwang, 2016/02/08 20:03:33]

Good point. But I still feel AsHumanReadableString(DecoderBuffer::kShortFormat)
is too long. How about we have two functions ToVerboseString() and ToString()? I
think you had something like this before. Sorry for going back and forth on
this.

 
   // Replaces any existing side data with data copied from |side_data|.
   void CopySideDataFrom(const uint8_t* side_data, size_t side_data_size);