Add MediaCodecAudioDecoder implementation

media/base/decoder_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DECODER_BUFFER_H_
 #define MEDIA_BASE_DECODER_BUFFER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 21 matching lines @@
 //
 // Also includes decoder specific functionality for decryption.
 //
 // NOTE: It is illegal to call any method when end_of_stream() is true.
 class MEDIA_EXPORT DecoderBuffer
     : public base::RefCountedThreadSafe<DecoderBuffer> {
  public:
   enum {
     kPaddingSize = 32,
 #if defined(ARCH_CPU_ARM_FAMILY)
-    kAlignmentSize = 16
+    kAlignmentSize = 16,
 #else
-    kAlignmentSize = 32
+    kAlignmentSize = 32,
 #endif
+    // A flag gor AsHumanReadableString()

[xhwang, 2016/02/05 21:37:36]

s/gor/for/

[Tima Vaisburd, 2016/02/06 03:54:11]

Deleted.

+    kShortFormat = 1,
   };
 
   // Allocates buffer with |size| >= 0.  Buffer will be padded and aligned
   // as necessary, and |is_key_frame_| will default to false.
   explicit DecoderBuffer(size_t size);
 
   // Create a DecoderBuffer whose |data_| is copied from |data|.  Buffer will be
   // padded and aligned as necessary.  |data| must not be NULL and |size| >= 0.
   // The buffer's |is_key_frame_| will default to false.
   static scoped_refptr<DecoderBuffer> CopyFrom(const uint8_t* data,
@@ skipping 110 matching lines @@
     DCHECK(!end_of_stream());
     return is_key_frame_;
   }
 
   void set_is_key_frame(bool is_key_frame) {
     DCHECK(!end_of_stream());
     is_key_frame_ = is_key_frame;
   }
 
   // Returns a human-readable string describing |*this|.
-  std::string AsHumanReadableString();
+  std::string AsHumanReadableString(int flags = 0);

[xhwang, 2016/02/05 21:37:36]

|flags| is very ambiguous... I would like "bool verbose = false" more. Also that
can save an extra enum.

[Tima Vaisburd, 2016/02/06 03:54:11]

I humbly disagree. The usage ... << AsHumanReadableString(false)  ... would
stumble me (why false? what is false? ah, he meant short format..) and even if
you remember now that false means short soon you will wonder what this means
exactly. AsHumanReadableString(SHORT_FORMAT) is more descriptive.

Because of the disagreement let's revert this change, I can deal with long
format.

[xhwang, 2016/02/08 20:03:33]

Good point. But I still feel AsHumanReadableString(DecoderBuffer::kShortFormat)
is too long. How about we have two functions ToVerboseString() and ToString()? I
think you had something like this before. Sorry for going back and forth on
this.

 
   // Replaces any existing side data with data copied from |side_data|.
   void CopySideDataFrom(const uint8_t* side_data, size_t side_data_size);
 
  protected:
   friend class base::RefCountedThreadSafe<DecoderBuffer>;
 
   // Allocates a buffer of size |size| >= 0 and copies |data| into it.  Buffer
   // will be padded and aligned as necessary.  If |data| is NULL then |data_| is
   // set to NULL and |buffer_size_| to 0.  |is_key_frame_| will default to
@@ skipping 19 matching lines @@
 
   // Constructor helper method for memory allocations.
   void Initialize();
 
   DISALLOW_COPY_AND_ASSIGN(DecoderBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DECODER_BUFFER_H_