Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1651653002: Verify AST instead of constant values. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -112 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 10 chunks +20 lines, -42 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 7 chunks +97 lines, -62 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-01-29 22:51:45 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-01-29 22:54:33 UTC) #2
scheglov
4 years, 10 months ago (2016-01-29 22:56:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb4a056948c147f74fd3dc482fa89f6f27dbcf0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698