pkg/analyzer/lib/src/summary/summarize_const_expr.dart - Issue 1651653002: Verify AST instead of constant values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

Issue 1651653002: Verify AST instead of constant values. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart

index 4787700123cfdec62cc340613eecb38a7ee8045a..8d4f97bcb202af9153f28c9a6149c9fcff625a06 100644

--- a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart

@@ -168,8 +168,7 @@ abstract class AbstractConstExprSerializer {

if (operator == TokenType.EQ_EQ) {

operations.add(UnlinkedConstOperation.equal);

} else if (operator == TokenType.BANG_EQ) {

- operations.add(UnlinkedConstOperation.equal);

- operations.add(UnlinkedConstOperation.not);

+ operations.add(UnlinkedConstOperation.notEqual);

} else if (operator == TokenType.AMPERSAND_AMPERSAND) {

operations.add(UnlinkedConstOperation.and);

} else if (operator == TokenType.BAR_BAR) {