Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1651603004: Revert of Update SK_IMAGE_VERSION to test RAW (Closed)

Created:
4 years, 10 months ago by scroggo
Modified:
4 years, 10 months ago
Reviewers:
msarett, borenet
CC:
reviews_skia.org, ebrauer, msarett, yujieqin, kinan
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update SK_IMAGE_VERSION to test RAW (patchset #1 id:1 of https://codereview.chromium.org/1612113002/ ) Reason for revert: https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93 seems to have caused problems, but it allows us to test RAW. In order to reland this, we'll need to reland that one, or have a simpler fix to disable RAW on platforms where it's not supported (e.g. ChromeOS) Original issue's description: > Update SK_IMAGE_VERSION to test RAW > > Once https://codereview.chromium.org/1520403003/ lands, we can start > testing RAW images. I have already added RAW images to a folder named > v2/; this updates the version so the script (once written) will check > the new version. > > Depends on skbug.com/4558 > > BUG=skia:4829 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612113002 > > Committed: https://skia.googlesource.com/skia/+/317a45e879889f9ed876549a10bbfd51aab41b45 TBR=borenet@google.com,msarett@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4829 Committed: https://skia.googlesource.com/skia/+/e82a6c7e71090c218e773fd2f7af6622490d892a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M SK_IMAGE_VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
Created Revert of Update SK_IMAGE_VERSION to test RAW
4 years, 10 months ago (2016-01-29 22:02:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651603004/1
4 years, 10 months ago (2016-01-29 22:03:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651603004/1
4 years, 10 months ago (2016-01-29 22:32:21 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 22:32:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e82a6c7e71090c218e773fd2f7af6622490d892a

Powered by Google App Engine
This is Rietveld 408576698