Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1651603003: Subzero. ARM32. Enables obj output. (Closed)

Created:
4 years, 10 months ago by John
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. ARM32. Enables obj output. This CL implements two little pieces of the lowering that are needed for --filetype=obj support in arm. With this change, spec2k builds and verifies with --filetype=obj BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076 R=kschimpf@google.com, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7d59513d0ffba4d70e6c5d31975f4464fcac35ba

Patch Set 1 #

Patch Set 2 : git pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M Makefile.standalone View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
John
4 years, 10 months ago (2016-01-29 20:53:06 UTC) #2
Karl
lgtm
4 years, 10 months ago (2016-01-29 20:57:38 UTC) #3
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-01-29 21:13:43 UTC) #4
John
4 years, 10 months ago (2016-02-01 20:43:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d59513d0ffba4d70e6c5d31975f4464fcac35ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698