Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: src/IceTargetLoweringARM32.cpp

Issue 1651603003: Subzero. ARM32. Enables obj output. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: git pull Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.cpp
diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp
index 72ba954e5a1f127952489fc635234ede22d0c013..f284f4d3bae54391afd2ceb65cd87a56e9632c4f 100644
--- a/src/IceTargetLoweringARM32.cpp
+++ b/src/IceTargetLoweringARM32.cpp
@@ -6437,9 +6437,11 @@ void TargetDataARM32::lowerConstants() {
if (Ctx->getFlags().getDisableTranslation())
return;
switch (Ctx->getFlags().getOutFileType()) {
- case FT_Elf:
- UnimplementedError(Ctx->getFlags());
- break;
+ case FT_Elf: {
+ ELFObjectWriter *Writer = Ctx->getObjectWriter();
+ Writer->writeConstantPool<ConstantFloat>(IceType_f32);
+ Writer->writeConstantPool<ConstantDouble>(IceType_f64);
+ } break;
case FT_Asm:
case FT_Iasm: {
OstreamLocker _(Ctx);
@@ -6455,7 +6457,9 @@ void TargetDataARM32::lowerJumpTables() {
return;
switch (Ctx->getFlags().getOutFileType()) {
case FT_Elf:
- UnimplementedError(Ctx->getFlags());
+ if (!Ctx->getJumpTables().empty()) {
+ llvm::report_fatal_error("ARM32 does not support jump tables yet.");
+ }
break;
case FT_Asm:
// Already emitted from Cfg
« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698