Issue 1651413003: Fix crash in NavigationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1651413003: Fix crash in NavigationHandle (Closed)

Created:
4 years, 10 months ago by mnaganov (inactive)

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

Fix crash in NavigationHandle This CL fixes a crash in NavigationHandleImpl when a Throttle tries to resume a navigation twice. A check was hit in NavigationHandleImpl::Resume, now the function will just be a no-op in that case. BUG=570200 Review URL: https://codereview.chromium.org/1610583002 Cr-Commit-Position: refs/heads/master@{#370371} (cherry picked from commit 21b595f137ee6444093751a0e659127f72df53f2) Committed: https://chromium.googlesource.com/chromium/src/+/85a7d7ad8e0b08e286e15d475166a4389a4f7f29

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	content/browser/frame_host/navigation_handle_impl.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

mnaganov (inactive)

4 years, 10 months ago (2016-02-02 20:13:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
85a7d7ad8e0b08e286e15d475166a4389a4f7f29.