Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1610583002: Fix crash in NavigationHandle (Closed)

Created:
4 years, 11 months ago by clamy
Modified:
4 years, 11 months ago
Reviewers:
carlosk
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@change-did-start-loading-logic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in NavigationHandle This CL fixes a crash in NavigationHandleImpl when a Throttle tries to resume a navigation twice. A check was hit in NavigationHandleImpl::Resume, now the function will just be a no-op in that case. BUG=570200 Committed: https://crrev.com/21b595f137ee6444093751a0e659127f72df53f2 Cr-Commit-Position: refs/heads/master@{#370371}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
clamy
@carlosk:PTAL
4 years, 11 months ago (2016-01-20 10:55:20 UTC) #3
carlosk
LGTM
4 years, 11 months ago (2016-01-20 12:38:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610583002/20001
4 years, 11 months ago (2016-01-20 12:39:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 12:43:57 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 12:45:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21b595f137ee6444093751a0e659127f72df53f2
Cr-Commit-Position: refs/heads/master@{#370371}

Powered by Google App Engine
This is Rietveld 408576698