Issue 1651313002: Merge to XFA: Tidy up CPDF_DocEnvironment::JS_* methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1651313002: Merge to XFA: Tidy up CPDF_DocEnvironment::JS_* methods (Closed)

Created:
4 years, 10 months ago by Tom Sepez

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Tidy up CPDF_DocEnvironment::JS_* methods One trivial conflict in fsdk_mgr.h Review URL: https://codereview.chromium.org/1658853002 . (cherry picked from commit 1654972e0c81f1841653f803903cc48b93f1738e) R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5702859df047cfe42c1ad64b65146600917709a0

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -137 lines)			Patch
	M	fpdfsdk/include/fsdk_mgr.h	View		3 chunks	+37 lines, -50 lines	0 comments	Download
	M	fpdfsdk/src/fsdk_mgr.cpp	View		5 chunks	+100 lines, -87 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

4 years, 10 months ago (2016-02-01 23:49:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5702859df047cfe42c1ad64b65146600917709a0 (presubmit successful).