Tidy up CPDF_DocEnvironment::JS_* methods

Tidy up CPDF_DocEnvironment::JS_* methods

Remove code from header.
Put related declarations together.
Add convenience function for widestrings.
Avoid pointless releases.
Use early returns in all cases for consistency.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/1654972e0c81f1841653f803903cc48b93f1738e

[Tom Sepez, 2016-02-01 23:06:58]

Description was changed from

==========
Tidy up CPDF_DocEnvironment::JS_* methods
==========

to

==========
Tidy up CPDF_DocEnvironment::JS_* methods

Remove code from header.
Put related declarations together.
Add convenience function for widestrings.
Avoid pointless releases.
==========

[Tom Sepez, 2016-02-01 23:06:58]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-01 23:08:19]

Description was changed from

==========
Tidy up CPDF_DocEnvironment::JS_* methods

Remove code from header.
Put related declarations together.
Add convenience function for widestrings.
Avoid pointless releases.
==========

to

==========
Tidy up CPDF_DocEnvironment::JS_* methods

Remove code from header.
Put related declarations together.
Add convenience function for widestrings.
Avoid pointless releases.
Use early returns in all cases for consistency.
==========

[Tom Sepez, 2016-02-01 23:08:30]

Lei, for review.

[Lei Zhang, 2016-02-01 23:22:09]

lgtm with some more exclaimation marks.

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (right):

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:246: m_pInfo->m_pJsPlatform->app_response) {
Missing '!'

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:260: if (!m_pInfo || !m_pInfo->m_pJsPlatform ||
m_pInfo->m_pJsPlatform->app_beep) {
Missing '!'

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:309: if (!m_pInfo || m_pInfo->m_pJsPlatform ||
missing '!'

[Tom Sepez, 2016-02-01 23:38:13]

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (right):

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:246: m_pInfo->m_pJsPlatform->app_response) {
On 2016/02/01 23:22:09, Lei Zhang wrote:
> Missing '!'

yikes.

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:260: if (!m_pInfo || !m_pInfo->m_pJsPlatform ||
m_pInfo->m_pJsPlatform->app_beep) {
On 2016/02/01 23:22:09, Lei Zhang wrote:
> Missing '!'

Done.

https://codereview.chromium.org/1658853002/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:309: if (!m_pInfo || m_pInfo->m_pJsPlatform ||
On 2016/02/01 23:22:09, Lei Zhang wrote:
> missing '!'

Done.

[Tom Sepez, 2016-02-01 23:38:42]

Description was changed from

==========
Tidy up CPDF_DocEnvironment::JS_* methods

Remove code from header.
Put related declarations together.
Add convenience function for widestrings.
Avoid pointless releases.
Use early returns in all cases for consistency.
==========

to

==========
Tidy up CPDF_DocEnvironment::JS_* methods

Remove code from header.
Put related declarations together.
Add convenience function for widestrings.
Avoid pointless releases.
Use early returns in all cases for consistency.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/1654972e0c81f1841653f803903cc48b93f1...
==========

[Tom Sepez, 2016-02-01 23:38:43]

Committed patchset #2 (id:20001) manually as
1654972e0c81f1841653f803903cc48b93f1738e (presubmit successful).