Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1651253003: More *_STRING_WRAPPER_ELEMENTS fixes (Closed)

Created:
4 years, 10 months ago by Jakob Kummerow
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

More *_STRING_WRAPPER_ELEMENTS fixes BUG=chromium:583257 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/d582d2bb2ac468acc0b5df64fae9407a01713c48 Cr-Commit-Position: refs/heads/master@{#33683}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ...and one more fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M src/elements.cc View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-583257.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
4 years, 10 months ago (2016-02-02 12:49:21 UTC) #1
Yang
On 2016/02/02 12:49:21, Jakob wrote: lgtm.
4 years, 10 months ago (2016-02-02 13:02:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651253003/40001
4 years, 10 months ago (2016-02-02 13:08:27 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-02 13:45:52 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 13:51:10 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d582d2bb2ac468acc0b5df64fae9407a01713c48
Cr-Commit-Position: refs/heads/master@{#33683}

Powered by Google App Engine
This is Rietveld 408576698