src/objects.cc - Issue 1651253003: More *_STRING_WRAPPER_ELEMENTS fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1651253003: More *_STRING_WRAPPER_ELEMENTS fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: ...and one more fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 258f806818a83067e8576d28ac6d87ed6387690a..3b41cd22ecb669ccb3eb5d65a12a2ac41025e58b 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -7908,7 +7908,8 @@ Maybe<bool> JSObject::PreventExtensionsWithTransition(

if (transition != NULL) {

Handle<Map> transition_map(transition, isolate);

DCHECK(transition_map->has_dictionary_elements() ||

- transition_map->has_fixed_typed_array_elements());

+ transition_map->has_fixed_typed_array_elements() ||

+ transition_map->elements_kind() == SLOW_STRING_WRAPPER_ELEMENTS);

DCHECK(!transition_map->is_extensible());

JSObject::MigrateToMap(object, transition_map);

} else if (TransitionArray::CanHaveMoreTransitions(old_map)) {

« no previous file with comments | « src/elements.cc ('k') | test/mjsunit/regress/regress-crbug-583257.js » ('j') | no next file with comments »