Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1651153005: changes QUIC negotiation about max open streams which effects server (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, danzh1
Base URL:
https://chromium.googlesource.com/chromium/src.git@113042237
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

changes QUIC negotiation about max open streams which effects server create outgoing stream and client create incoming stream behaviors which are not in use yet.Flag protected by FLAGS_quic_different_max_num_open_streams. Seperate max_open_stream_ to be max_open_incoming/outgoing_stream_ to make creating outgoing stream strickly below max open stream limit but creating incoming stream a little above limit in case of race condition. This cl is to make server push to work in the same way as client sending requests. Merge internal change: 113049250 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -60 lines) Patch
M net/quic/quic_chromium_client_session.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 3 chunks +14 lines, -6 lines 0 comments Download
M net/quic/quic_session.cc View 8 chunks +47 lines, -23 lines 0 comments Download
M net/quic/quic_session_test.cc View 9 chunks +56 lines, -10 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-02 04:05:35 UTC) #1
Ryan Hamilton
4 years, 10 months ago (2016-02-02 04:31:46 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698