Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Unified Diff: net/tools/quic/quic_server_session_base_test.cc

Issue 1651153005: changes QUIC negotiation about max open streams which effects server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113042237
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_server_session_base.cc ('k') | net/tools/quic/quic_simple_server_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_server_session_base_test.cc
diff --git a/net/tools/quic/quic_server_session_base_test.cc b/net/tools/quic/quic_server_session_base_test.cc
index 45e5223622f6f7f0b1555a9141faeddfbce273e3..85e33010956bc706f5694cf5f39fc17cff6cb8f8 100644
--- a/net/tools/quic/quic_server_session_base_test.cc
+++ b/net/tools/quic/quic_server_session_base_test.cc
@@ -237,12 +237,12 @@ TEST_P(QuicServerSessionBaseTest, MaxOpenStreams) {
// The slightly increased stream limit is set during config negotiation. It
// is either an increase of 10 over negotiated limit, or a fixed percentage
// scaling, whichever is larger. Test both before continuing.
- EXPECT_EQ(kMaxStreamsForTest, session_->get_max_open_streams());
+ EXPECT_EQ(kMaxStreamsForTest, session_->max_open_incoming_streams());
session_->OnConfigNegotiated();
EXPECT_LT(kMaxStreamsMultiplier * kMaxStreamsForTest,
kMaxStreamsForTest + kMaxStreamsMinimumIncrement);
EXPECT_EQ(kMaxStreamsForTest + kMaxStreamsMinimumIncrement,
- session_->get_max_open_streams());
+ session_->max_open_incoming_streams());
EXPECT_EQ(0u, session_->GetNumOpenIncomingStreams());
QuicStreamId stream_id = kClientDataStreamId1;
// Open the max configured number of streams, should be no problem.
@@ -280,11 +280,12 @@ TEST_P(QuicServerSessionBaseTest, MaxAvailableStreams) {
// stream limit to deal with rare cases where a client FIN/RST is lost.
// The slightly increased stream limit is set during config negotiation.
- EXPECT_EQ(kMaxStreamsForTest, session_->get_max_open_streams());
+ EXPECT_EQ(kMaxStreamsForTest, session_->max_open_incoming_streams());
session_->OnConfigNegotiated();
- const size_t kAvailableStreamLimit = session_->get_max_available_streams();
- EXPECT_EQ(session_->get_max_open_streams() * kMaxAvailableStreamsMultiplier,
- session_->get_max_available_streams());
+ const size_t kAvailableStreamLimit = session_->MaxAvailableStreams();
+ EXPECT_EQ(
+ session_->max_open_incoming_streams() * kMaxAvailableStreamsMultiplier,
+ session_->MaxAvailableStreams());
// The protocol specification requires that there can be at least 10 times
// as many available streams as the connection's maximum open streams.
EXPECT_LE(10 * kMaxStreamsForTest, kAvailableStreamLimit);
« no previous file with comments | « net/tools/quic/quic_server_session_base.cc ('k') | net/tools/quic/quic_simple_server_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698