Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1651023003: Fix EOF detection when reading an entire file (Closed)

Created:
4 years, 10 months ago by Søren Gjesse
Modified:
4 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/io/file_impl.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Søren Gjesse
4 years, 10 months ago (2016-02-01 08:05:00 UTC) #1
kustermann
LGTM
4 years, 10 months ago (2016-02-01 08:53:04 UTC) #2
Søren Gjesse
4 years, 10 months ago (2016-02-01 09:09:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca7ee2b6cd6f589d488eb761c1857428df027f7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698