Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 1650843002: Fix new -Wconstant-conversion versions after clang r259271 (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix new -Wconstant-conversion versions after clang r259271 http://llvm.org/viewvc/llvm-project?view=revision&revision=259271 made clang's -Wconversion stricter. This (together with https://chromium-review.googlesource.com/#/c/324860/) fixes all new instances in a chromium/mac build. No behavior change. BUG=none Committed: https://crrev.com/4e290e7f917999417eb38ed840c3dc2dde75881a Cr-Commit-Position: refs/heads/master@{#372689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M rlz/lib/machine_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/battor_agent/battor_connection_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 10 months ago (2016-01-31 00:26:59 UTC) #2
hans
lgtm
4 years, 10 months ago (2016-02-01 17:02:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650843002/1
4 years, 10 months ago (2016-02-01 17:33:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 18:26:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 18:28:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e290e7f917999417eb38ed840c3dc2dde75881a
Cr-Commit-Position: refs/heads/master@{#372689}

Powered by Google App Engine
This is Rietveld 408576698