tools/battor_agent/battor_connection_impl_unittest.cc - Issue 1650843002: Fix new -Wconstant-conversion versions after clang r259271

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/battor_agent/battor_connection_impl_unittest.cc

Issue 1650843002: Fix new -Wconstant-conversion versions after clang r259271 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/battor_agent/battor_connection_impl_unittest.cc

diff --git a/tools/battor_agent/battor_connection_impl_unittest.cc b/tools/battor_agent/battor_connection_impl_unittest.cc

index fffed6ab062291d4226f31e5e5bd828a93d87bfb..a1b8540fe9ab81bda895a7f78186d8917005edfe 100644

--- a/tools/battor_agent/battor_connection_impl_unittest.cc

+++ b/tools/battor_agent/battor_connection_impl_unittest.cc

@@ -198,7 +198,7 @@ TEST_F(BattOrConnectionImplTest, ReadMessageInvalidType) {

const char data[] = {

BATTOR_CONTROL_BYTE_START,

- UINT8_MAX,

+ static_cast<char>(UINT8_MAX),

BATTOR_CONTROL_BYTE_ESCAPE,

BATTOR_CONTROL_MESSAGE_TYPE_RESET,

0x04,

« no previous file with comments | « rlz/lib/machine_id_unittest.cc ('k') | no next file » | no next file with comments »