Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1650673002: Follow on to moving wheel_event_handlers to LayerTreeView (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
CC:
aelias_OOO_until_Jul13, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow on to moving wheel_event_handlers to LayerTreeView Through reading some code I discovered a potential issue in commit ee0b6981de62e9a234d031eab793da8d7752197b (https://codereview.chromium.org/1639363002) I moved the callback to setting the wheel event handlers onto the ChromeClient. It appears WebPagePopupImpl extends the EmptyChromeClient and it should likely call the appropriate things on the layer tree view it owns. Also added setTouchAction call since I think it should be implemented. BUG=489802 Committed: https://crrev.com/7f7ce9caac6d3ea2938ac067cf769bc53d2781cc Cr-Commit-Position: refs/heads/master@{#372452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
dtapuska
4 years, 10 months ago (2016-01-29 20:21:25 UTC) #3
aelias_OOO_until_Jul13
lgtm (note that I have OWNERS over Source/web)
4 years, 10 months ago (2016-01-29 20:24:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650673002/1
4 years, 10 months ago (2016-01-29 22:03:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 23:11:30 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 23:12:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f7ce9caac6d3ea2938ac067cf769bc53d2781cc
Cr-Commit-Position: refs/heads/master@{#372452}

Powered by Google App Engine
This is Rietveld 408576698